Follow up on object store selection PR. #15654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setup abstractions to prevent sharing transient or private per-user objects in an objectstore.
jmchilton
force-pushed
the
object_store_ui_followup
branch
2 times, most recently
from
6f879e2 to
bceca92
Compare
jmchilton
force-pushed
the
object_store_ui_followup
branch
from
bceca92 to
c4671c7
Compare
jmchilton
force-pushed
the
object_store_ui_followup
branch
from
01d2fa7 to
c40672a
Compare
I had started by using fa-database everywhere but then I implemented the user selection piece and that icon was already used for custom DB keys and then David implemented the storage management functionality and so that icon couldn't be used in the history either. This I think switches everything else over to the now more consitent fa-hdd.
3 tasks
|
Not done refining this functionality - but I think these are all atomic changes and fixes some presentational issues to give this functionality a better first impression... and the PR is green 😆 so I'm marking this as ready for review and I'll collect more issues and fixes other places. |
mvdbeek
reviewed
Mar 3, 2023
| @@ -74,11 +75,18 @@ | |||
|
|
|||
| UserIdPathParam: DecodedDatabaseIdField = Path(..., title="User ID", description="The ID of the user to get.") | |||
| APIKeyPathParam: str = Path(..., title="API Key", description="The API key of the user.") | |||
| FlexibleUserIdPathParam: str = Path(..., title="User ID", description="The ID of the user to get or __current__.") | |||
There was a problem hiding this comment.
I think the type should be a union of EncodedDatabaseId and the literal current here.
mvdbeek
reviewed
Mar 3, 2023
| :history-preferred-object-store-id="historyPreferredObjectStoreId" | ||
| :user="user"> | ||
| </PreferredStorePopover> | ||
| <ConfigProvider v-slot="{ config }"> |
There was a problem hiding this comment.
Can you use the useConfig(true) composable here please ? The ConfigProvider triggers a new fetch every time.
mvdbeek
approved these changes
Mar 3, 2023
24 tasks
|
More follow up issues are being tracked in #15692. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of non-functional changes that would modernize the object store selection PR #14073 - it is a project I would love to delegate but I'm going to work through them until the PR is merged in case that doesn't materialize.
Bigger projects:
How to test the changes?
(Select all options that apply)
License