Base code for modernization FTP Form connection to Modal with TODOs. #15622
+256
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is in draft mode. |
dannon
reviewed
Feb 24, 2023
| }, | ||
| methods: { | ||
| /** Fill table with ftp entries */ | ||
| _renderTable: function () { |
There was a problem hiding this comment.
Please break this down and generate the tabular data in a computed to bind to a standard vue table component.
There was a problem hiding this comment.
@guerler @ElectronicBlueberry For this change request on my PR, would appreciate some guidance via this QA Branch's PR with instructions (not for merge, just to locally QA the FTP component).
hujambo-dunia
force-pushed
the
forms-modern-ftp
branch
from
3b71413 to
db9ca6a
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for issue #12878
(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)
How to test the changes?
(Select all options that apply)
License