[WIP] Implement abstractions to annotate non-sharable datasets & objectstores. #14044
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sketched out so far:
private
- indicating datasets stored in them should not be shared.sharable
property tomodel.Dataset
that checks itsobject_store_id
against the configured object store to determine if it is not stored in aprivate
objectstore.security_agent
to check if a dataset is restricted to a single user and augmentgalaxy.jobs.JobWrapper._set_object_store_ids
andObjectStorePopulator
to prevent jobs that might create non-private datasets in private objectstores.Left to do:
xrefs:
How to test the changes?
(Select all options that apply)
License