Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jquery.complexify from everywhere #13228

Merged
merged 10 commits into from
Jan 25, 2022
Merged

Remove jquery.complexify from everywhere #13228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
716c462
Remove and unload `jquery.complexify` package
itisAliRH Jan 23, 2022
ca47d97
Replace check password strength in toolshed change_password
itisAliRH Jan 23, 2022
a232e2e
Replace check password strength in toolshed register
itisAliRH Jan 23, 2022
e48b5d3
Update change_password.mako
itisAliRH Jan 23, 2022
ad3fd44
Remove and unload `jquery.complexify` package
itisAliRH Jan 23, 2022
04ed8f1
Replace check password strength in toolshed change_password
itisAliRH Jan 23, 2022
c41b890
Replace check password strength in toolshed register
itisAliRH Jan 23, 2022
98d2a34
Update change_password.mako
itisAliRH Jan 23, 2022
aca6e81
Merge branch 'Remove-`jquery.complexify`-from-everywhere' of https://…
Jan 24, 2022
f23f5d9
Remove toolshed `password strength` from `register` and `change passw…
itisAliRH Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion client/gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const paths = {
backbone: ["backbone.js", "backbone.js"],
"@galaxyproject/bootstrap-tour": ["build/js/bootstrap-tour.js", "bootstrap-tour.js"],
jquery: ["dist/jquery.js", "jquery/jquery.js"],
"jquery.complexify": ["jquery.complexify.js", "jquery/jquery.complexify.js"],
"jquery.cookie": ["jquery.cookie.js", "jquery/jquery.cookie.js"],
"jquery-migrate": ["dist/jquery-migrate.js", "jquery/jquery.migrate.js"],
"jquery-mousewheel": ["jquery.mousewheel.js", "jquery/jquery.mousewheel.js"],
Expand Down
1 change: 0 additions & 1 deletion client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
"jquery-migrate": "~1.4",
"jquery-mousewheel": "^3.1.13",
"jquery-ui": "^1.12.1",
"jquery.complexify": "^0.5.2",
"jquery.cookie": "^1.4.1",
"jspdf": "^2.4.0",
"linkifyjs": "^2.1.9",
Expand Down
1 change: 0 additions & 1 deletion client/src/libs/jquery.custom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ require("imports-loader?imports=default|jqueryVendor|jQuery!libs/farbtastic");
//require("imports-loader?imports=default|jquery|jqueryVendor,define=>false!jquery.cookie");
require("imports-loader?imports=default|jqueryVendor|jQuery!libs/jquery/jquery.dynatree");
require("imports-loader?imports=default|jqueryVendor|jQuery!libs/jquery/jquery.wymeditor");
require("imports-loader?imports=default|jqueryVendor|jQuery!jquery.complexify");
require("imports-loader?imports=default|jqueryVendor|jQuery!jquery-migrate");

// require("imports-loader?jQuery=jqueryVendor!../ui/autocom_tagging");
Expand Down
5 changes: 0 additions & 5 deletions client/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7509,11 +7509,6 @@ jquery-ui@^1.12.1:
dependencies:
jquery ">=1.8.0 <4.0.0"

jquery.complexify@^0.5.2:
version "0.5.2"
resolved "https://registry.yarnpkg.com/jquery.complexify/-/jquery.complexify-0.5.2.tgz#8c8834ca08cee9476f1d975128d49526adcc4ae9"
integrity sha1-jIg0ygjO6UdvHZdRKNSVJq3MSuk=

jquery.cookie@^1.4.1:
version "1.4.1"
resolved "https://registry.yarnpkg.com/jquery.cookie/-/jquery.cookie-1.4.1.tgz#d63dce209eab691fe63316db08ca9e47e0f9385b"
Expand Down
15 changes: 0 additions & 15 deletions lib/tool_shed/webapp/templates/webapps/tool_shed/user/change_password.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,4 @@
<%inherit file="/base.mako"/>
<script>
$(function() {
$("[name='password']").complexify({'minimumChars':6}, function(valid, complexity){
var progressBar = $('.progress-bar');
var color = valid ? 'lightgreen' : 'red';
progressBar.css('background-color', color);
progressBar.css({'width': complexity + '%'});
});
});
</script>

<div class="toolForm">
<form name="change_password" id="change_password" action="${h.url_for( controller='user', action='change_password' )}" method="post" >
Expand All @@ -26,11 +16,6 @@ $(function() {
<label>New password:</label>
<input type="password" name="password" value="" size="40"/>
</div>
<div class="progress">
<div id="complexity-bar" class="progress-bar" role="progressbar">
Strength
</div>
</div>
<div class="form-row">
<label>Confirm:</label>
<input type="password" name="confirm" value="" size="40"/>
Expand Down
13 changes: 0 additions & 13 deletions lib/tool_shed/webapp/templates/webapps/tool_shed/user/register.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,14 +77,6 @@
$(".errormessage").html(message);
}

$("[name='password']").complexify({'minimumChars':6}, function(valid, complexity){
var progressBar = $('.progress-bar');
var color = valid ? 'lightgreen' : 'red';

progressBar.css('background-color', color);
progressBar.css({'width': complexity + '%'});
});

$('#registration').bind('submit', function(e) {
$('#send').attr('disabled', 'disabled');

Expand Down Expand Up @@ -130,11 +122,6 @@
<label>Password:</label>
<input id="password_input" type="password" name="password" value="" size="40"/>
</div>
<div class="progress">
<div id="complexity-bar" class="progress-bar" role="progressbar">
Strength
</div>
</div>
<div class="form-row">
<label>Confirm password:</label>
<input id="password_check_input" type="password" name="confirm" value="" size="40"/>
Expand Down