Add CWL conformance API tests #12966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
approved these changes
Nov 23, 2021
…w()`
Also:
- Replace deprecated `workflows/{workflow_id}/usage` API endpoint with
`workflows/{workflow_id}/invocations`
1) Download conformance tests to `test/functional/tools/cwl_tools` where they can be used also by framework and unit tests in the future. 2) Add populators to enable executing CWL conformance tests 3) Generate CWL conformance API tests only when needed for tests
nsoranzo
force-pushed
the
cwl_conformance_tests
branch
from
2bd1f4a to
6a6c4f8
Compare
jmchilton
approved these changes
Nov 23, 2021
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/functional/tools/cwl_toolswhere they can be used also by framework and unit tests in the future.BaseCwlWorkflowTestCaseandCwlPopulatorto enable executing CWL conformance testsThis is around 1/4 of the big CWL PR #12909 . Here I've split the changes in commits as small and coherent as possible, and refactored some code, in particular in
CwlPopulator.The conformance tests marked
green(i.e those not listed inRED_TESTSinscripts/cwl_conformance_to_test_cases.py) are the ones that pass with all the other changes included in #12909 and should not be expected to pass here. However, when trying to run them as specified below, the test cases and populators work properly and the tests should fail with errors expected at this stage, like:How to test the changes?
(Select all options that apply)
./run_tests.sh -cwl lib/galaxy_test/api/cwl -- -m 'green and cwl_conformance_v1_0'License