Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vueify Generic Form Wrapper #12329

Merged
merged 21 commits into from
Aug 14, 2021
Merged

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Aug 7, 2021

Requires #12323, related to #11076. This PR removes the final backbone based wrapper around form-view. It is widely used in the Analysis panel e.g. to set user preferences, create pages, workflows and other items. It is also used in the admin panel to configure users, groups and roles.

How to test the changes?

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these contributions under Galaxy's current license.
  • I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to [email protected].

@guerler guerler added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Aug 7, 2021
@guerler guerler added this to the 21.09 milestone Aug 7, 2021
@guerler guerler marked this pull request as ready for review August 9, 2021 03:10
@bgruening
Copy link
Member

@guerler we need a rebase here :-)

guerler added 21 commits August 10, 2021 14:28
@guerler guerler force-pushed the vueify_default_form_wrapper branch from f9c27f5 to b8c5c56 Compare August 10, 2021 18:33
@dannon dannon merged commit 0944b65 into galaxyproject:dev Aug 14, 2021
@guerler guerler deleted the vueify_default_form_wrapper branch August 16, 2021 03:03
@guerler
Copy link
Contributor Author

guerler commented Aug 16, 2021

Awesome, thanks for helping with this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants