Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass user to the ObjectStorePopulator #10231

Merged
merged 1 commit into from
Sep 16, 2020

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Sep 16, 2020

This code is taken from #4840 in order to simplify that branch for the review process.

@jmchilton's message:

Not used yet in Galaxy core yet, but useful for applications where you want object store selection to be based on user in some way. This code was taken from #4840. Part of this is trying to reduce the number of files that branch touches to make review easier - but I'm confident this extension point is good regardless. Also it makes it clear we need to keep the user object in the picture when assigning the object store ID in the future.

@VJalili VJalili mentioned this pull request Sep 16, 2020
@galaxybot galaxybot added this to the 21.01 milestone Sep 16, 2020
@VJalili VJalili requested a review from jmchilton September 16, 2020 09:06
@jmchilton jmchilton added area/objectstore kind/refactoring cleanup or refactoring of existing code, no functional changes and removed triage labels Sep 16, 2020
@jmchilton jmchilton merged commit 024f633 into galaxyproject:dev Sep 16, 2020
@jmchilton
Copy link
Member

Awesome - thanks!

@nsoranzo nsoranzo modified the milestones: 21.01, 20.09 Sep 16, 2020
@VJalili VJalili deleted the user_objectstore_populator branch September 16, 2020 18:49
mvdbeek added a commit to mvdbeek/galaxy that referenced this pull request Sep 21, 2020
The user argument is now mandatory.
Broken in galaxyproject#10231.
@VJalili VJalili restored the user_objectstore_populator branch March 22, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/objectstore kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants