Implement quota interface - with better logic isolation and unit tests. #10212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jmchilton
commented
Sep 11, 2020
•
jmchilton
commented
- Add 'interface' (abc) Quota agent with more documentation to define the interface jobs and user pieces have to quota management.
- Remove unused 'get_user_quotas' method from implementations of quota_agent.
- Add factory method to refactor logic for determining which quota agent to use out of galaxy/app and into galaxy.quota.
- Break get_quota into get_quota and get_quota_nice_size based on return type - I think return types varying so wildly based on input parameters is an anti-pattern.
- Unit tests that cover a lot of the complex get_quota logic.
- Integration test case for simple API testing of quotas.
- Refactor checking if quota is exceeded out of job.handler so it can be tested in isolation and so new functionality for quota calculation is extended in quota modules and not in job handler logic. I think this will make User-based ObjectStore #4840 a little cleaner.
jmchilton
added
the
kind/refactoring
jmchilton
force-pushed
the
quota_interface
branch
2 times, most recently
from
2fef5a9 to
30cbc41
Compare
jmchilton
changed the title
jmchilton
changed the title
Closed
jmchilton
force-pushed
the
quota_interface
branch
from
8404175 to
e17d4d2
Compare
jmchilton
force-pushed
the
quota_interface
branch
from
e17d4d2 to
2d35d06
Compare
jmchilton
force-pushed
the
quota_interface
branch
from
2d35d06 to
5e55693
Compare
jmchilton
force-pushed
the
quota_interface
branch
from
5e55693 to
d2a785b
Compare
- Add 'interface' (abc) Quota agent with more documentation to define the interface jobs and user pieces have to quota management. - Remove unused 'get_user_quotas' method from implementations of quota_agent. - Add factory method to refactor logic for determining which quota agent to use out of galaxy/app and into galaxy.quota. - Break get_quota into get_quota and get_quota_nice_size based on return type - I think return types varying so wildly based on input parameters is an anti-pattern.
jmchilton
force-pushed
the
quota_interface
branch
from
d2a785b to
b628309
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.