Rules Widget - Post Merge Smaller Tweaks

[jmchilton]

• Upload widget needs a "Close" button for the Rule-based tab, same as on the other tabs (Regular/Composite/Collection). (Suggested by @mblue9 on Rule-based Uploader / Builder #5365). (in Various Improvements for the Rule Builder Widget #5823)
• Upload widget needs reset button as well. (Suggested by @mblue9) (in Various Improvements for the Rule Builder Widget #5823)
• Instead of "Okay" button call it "Apply" when editing rules / mapping. (Suggested by @mblue9) (Various Improvements for the Rule Builder Widget #5823)
• X next to mapping to remove mapping in edit mode (this is only present in the outer display of the mappings I think). (Suggested by @mblue9) (in Various Improvements for the Rule Builder Widget #5823)
• Prevent "Build" until some data is present (reported by @martenson below).
• Reconsider the formatting of rule definitions (namely alignment, select width) (reported by @martenson below).
• Only allow selecting text formats or tabular formats in the dataset selection list in the upload widget (reported by @martenson below).
• Make genome selector wider (reported by @martenson below).
• Better handling of the textfield as datatype of the upload widget changes (reported by @martenson below).
• Allow name tags for collections:
  • Textbox by name if just one collection specified, read from table like name if multiple collections.
• Add drop target for text datasets. (Suggested by @mvdbeek.)
• Allow reading in tags - name tags and normal tags - from rule data for individual datasets.
• New filter - contains value.
• New column adder - split on character.
• Add checkbox requiring multiple collections to be matching - currently one can create two collections with the same structure but there is no way to force that they are the same structure and warn if they aren't. Would then implement UI to Support Creation of Matching Lists #3916.
• Allow setting path for uploads (for admins).
• Integrate with library import folder (nearly identical to FTP directory I think).
• Scrolling is a mess rule based uploader does not scroll well/at all #6100 (also reported on Rule based uploader issues / sharp edges #6220).
• The last set of ruled uploadings might force the closure of rules currently being worked on (reported in Rule based uploader issues / sharp edges #6220).
• Add button and browser state to allow reloading last rules.

Some migrated from #5380.

[martenson]

a few observations from latest dev

• we could add validation and do not allow to click build until some data is present
• when switching Load tabular data from: the textfields should be re-initialized. e.g. now when switching from value FTP directory the actual contents of FTP dir remain in the field
• dataset selection for the input might want to respect the datasets format? (e.g. I shouldn't be able to select a .gz datatype)
• It could be beneficial to make genome select2 wider
  
• reconsider the formatting of rule definitions (namely alignment, select width)
  

[jmchilton]

Thanks @martenson - I largely agree with these and have added them to the list above and I'll try to work on these soon. Are you sure about this bullet point though:

when switching Load tabular data from: the textfields should be re-initialized. e.g. now when switching from value FTP directory the actual contents of FTP dir remain in the field

The lazy re-initialization right now lets you for instance switch back to the other option if you realize you shouldn't have switched it without loosing data and it lets you switch to manual data entry after selecting FTP or a dataset or manually modify what is there before bringing it into the rule builder (exclude files or rows you don't want for instance). So it looks rough I suppose but it is more functional I think. I'm not going to claim these behaviors were intentional but I wonder if they are a good accident.

[martenson]

@jmchilton +1 for re-initialization from stored state, but I think you have at least 2, but rather 3 states to store (which is fine)

[jmchilton]

reconsider the formatting of rule definitions (namely alignment, select width)

@martenson I set a minimum width in my apply_rules branch - what were you thinking in terms of alignment? Put the column selectors below the labels, add some left-margin, etc?

[martenson]

@jmchilton I would align the column selectors and 'delete' icon to the right so you can navigate vertically between them with ease. Let me actually tinker with it a bit, I'll get back to you.

[martenson]

I am not able to scroll enough to the right to see the whole table. I would also consider adding explicit scrollbars there, on touchpad with gestures I often leave the dialogue when trying to scroll.

[jmchilton]

@martenson Do you know how to do that? Is this https://stackoverflow.com/a/7855592 the right answer?

[martenson]

I was hoping for something like

.table {
overflow-x:scroll;
overflow-y:scroll;
overflow:scroll;
}

But I do not have a recent experience, will give it a try in a bit.

[hexylena]

It would be nice to be able to:

• concatenate multiple columns in one operation
• have a joining character for the concatenation (e.g. ' ', -, _)