Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Slow performance when loading published histories #17665

Closed
davelopez opened this issue Mar 12, 2024 · 3 comments
Closed

[24.0] Slow performance when loading published histories #17665

davelopez opened this issue Mar 12, 2024 · 3 comments

Comments

@davelopez
Copy link
Contributor

davelopez commented Mar 12, 2024

Describe the bug
When loading published histories, it takes a considerable amount of time even if only 25 histories are loaded per request.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: 24.0
Commit: (run git rev-parse HEAD if you run this Galaxy server)

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://usegalaxy.org/histories/list_published
  2. Observe that displaying 25 histories takes a lot of time

Expected behavior
I should load 25 histories faster.

Screenshots
PublicHistoriesPerformance

Additional context
I think the issue (or part of it) might be that we are loading detailed views of those histories when we only need the summary, and then, we are requesting additional redundant details for each of the histories after the first load.

@jmchilton
Copy link
Member

We did a bunch of work a long time ago to optimize the mako versions of these grids - I think this meta issue linked to some of the issues we tackled #5473.

@mvdbeek
Copy link
Member

mvdbeek commented Mar 14, 2024

#17726 is also related here, I would assume that brings performance back down to pre-24.0

@jdavcs jdavcs added this to the 24.0 milestone Mar 18, 2024
@mvdbeek
Copy link
Member

mvdbeek commented Mar 19, 2024

We're at ~ 700ms now, fixing the view parameter in the API was key here. This is still kind of slow (though really not annoyingly so). I'm ready to attribute a lot of that to galaxyproject/usegalaxy-playbook#381. In any case this isn't somehting we need to fix for 24.0, and usegalaxy.eu also requires ~ 500ms. Given galaxyproject/usegalaxy-playbook#381 I would not assume there's a performance regression between the releases now.

@mvdbeek mvdbeek closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants