Revert unnecessary error change

Upgrade messages are collected via step.upgrade_messages. Addresses https://github.com/galaxyproject/galaxy/pull/17858/files#r1557810107
galaxyproject · Apr 9, 2024 · f71de43 · f71de43
1 parent f4c4019
commit f71de43
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/lib/galaxy/managers/workflows.py b/lib/galaxy/managers/workflows.py
@@ -1461,12 +1461,11 @@ def _workflow_to_dict_export(self, trans, stored=None, workflow=None, internal=F
             if not annotation_str and annotation_owner:
                 annotation_str = self.get_item_annotation_str(trans.sa_session, annotation_owner, step) or ""
             content_id = module.get_content_id() if allow_upgrade else step.content_id
-            errors = {}
             try:
                 tool_state = module.get_export_state()
             except ValueError:
                 # Fix state if necessary
-                errors = module.check_and_update_state()
+                module.check_and_update_state()
                 tool_state = module.get_export_state()
 
             # Step info
@@ -1478,7 +1477,7 @@ def _workflow_to_dict_export(self, trans, stored=None, workflow=None, internal=F
                 "tool_version": module.get_version() if allow_upgrade else step.tool_version,
                 "name": module.get_name(),
                 "tool_state": json.dumps(tool_state),
-                "errors": errors or module.get_errors(),
+                "errors": module.get_errors(),
                 "uuid": str(step.uuid),
                 "label": step.label or None,
                 "annotation": annotation_str,