Skip to content

Commit

Permalink
Decrease visualization log level
Browse files Browse the repository at this point in the history
Minor followup to #18211.
If we've got a MessageException I don't think we need to log this as an
error, since we're also showing a reasonable message to the user.
  • Loading branch information
mvdbeek committed May 27, 2024
1 parent d8b827f commit ed70432
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion lib/galaxy/webapps/galaxy/controllers/visualization.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
model,
web,
)
from galaxy.exceptions import MessageException
from galaxy.managers.hdas import HDAManager
from galaxy.managers.sharable import SlugBuilder
from galaxy.model.base import transaction
Expand Down Expand Up @@ -258,7 +259,10 @@ def _handle_plugin_error(self, trans, visualization_name, exception):
"""
Log, raise if debugging; log and show html message if not.
"""
log.exception("error rendering visualization (%s)", visualization_name)
if isinstance(exception, MessageException):
log.debug("error rendering visualization (%s): %s", visualization_name, exception)
else:
log.exception("error rendering visualization (%s)", visualization_name)
if trans.debug:
raise exception
return trans.show_error_message(
Expand Down

0 comments on commit ed70432

Please sign in to comment.