Skip to content

Commit

Permalink
Don't save in test_integer_input
Browse files Browse the repository at this point in the history
Reproduces #17970
  • Loading branch information
mvdbeek committed Apr 11, 2024
1 parent 206fe02 commit e2d737f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 7 deletions.
13 changes: 7 additions & 6 deletions lib/galaxy/selenium/navigates_galaxy.py
Original file line number Diff line number Diff line change
Expand Up @@ -1510,7 +1510,7 @@ def workflow_run_ensure_expanded(self):
workflow_run.expand_form_link.wait_for_and_click()
workflow_run.expanded_form.wait_for_visible()

def workflow_create_new(self, annotation=None, clear_placeholder=False):
def workflow_create_new(self, annotation=None, clear_placeholder=False, save_workflow=True):
self.workflow_index_open()
self.sleep_for(self.wait_types.UX_RENDER)
self.click_button_new_workflow()
Expand All @@ -1522,11 +1522,12 @@ def workflow_create_new(self, annotation=None, clear_placeholder=False):
name_component.wait_for_and_send_keys(name)
annotation = annotation or self._get_random_name()
self.components.workflow_editor.edit_annotation.wait_for_and_send_keys(annotation)
save_button = self.components.workflow_editor.save_button
save_button.wait_for_visible()
assert not save_button.has_class("disabled")
save_button.wait_for_and_click()
self.sleep_for(self.wait_types.UX_RENDER)
if save_workflow:
save_button = self.components.workflow_editor.save_button
save_button.wait_for_visible()
assert not save_button.has_class("disabled")
save_button.wait_for_and_click()
self.sleep_for(self.wait_types.UX_RENDER)
return name

def invocation_index_table_elements(self):
Expand Down
2 changes: 1 addition & 1 deletion lib/galaxy_test/selenium/test_workflow_editor.py
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ def test_data_column_input_editing(self):
def test_integer_input(self):
editor = self.components.workflow_editor

name = self.workflow_create_new()
name = self.workflow_create_new(save_workflow=False)
self.workflow_editor_add_input(item_name="parameter_input")
self.screenshot("workflow_editor_parameter_input_new")
editor.label_input.wait_for_and_send_keys("input1")
Expand Down

0 comments on commit e2d737f

Please sign in to comment.