Move assertions out request error handling

galaxyproject · May 29, 2024 · ce1582f · ce1582f
1 parent 5d2ccdf
commit ce1582f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/test/unit/app/managers/test_CitationsManager_db.py b/test/unit/app/managers/test_CitationsManager_db.py
@@ -35,8 +35,8 @@ def test_DoiCache(url_factory):  # noqa: F811
         try:
             assert "Jörg" in doi_cache.get_bibtex("10.1093/bioinformatics/bts252")
             assert "Özkurt" in doi_cache.get_bibtex("10.1101/2021.12.24.474111")
-            assert not is_cache_empty(db_url, "doi")
-            doi_cache._cache.clear()
-            assert is_cache_empty(db_url, "doi")
         except requests.exceptions.RequestException as e:
             raise SkipTest(f"dx.doi failed to respond: {e}")
+        assert not is_cache_empty(db_url, "doi")
+        doi_cache._cache.clear()
+        assert is_cache_empty(db_url, "doi")