Skip to content

Commit

Permalink
Merge pull request #18131 from mvdbeek/no_commit_in_delete_pja
Browse files Browse the repository at this point in the history
[24.0] Don't commit in ``DeleteIntermediatesAction``
  • Loading branch information
dannon authored May 14, 2024
2 parents fa3ef46 + b388b81 commit cd47ef6
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions lib/galaxy/job_execution/actions/post.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
from markupsafe import escape

from galaxy.model import PostJobActionAssociation
from galaxy.model.base import transaction
from galaxy.util import send_mail
from galaxy.util.custom_logging import get_logger

Expand Down Expand Up @@ -370,8 +369,6 @@ def execute(cls, app, sa_session, action, job, replacement_dict, final_job_state
# POTENTIAL ISSUES: When many outputs are being finish()ed
# concurrently, sometimes non-terminal steps won't be cleaned up
# because of the lag in job state updates.
with transaction(sa_session):
sa_session.commit()
if not job.workflow_invocation_step:
log.debug("This job is not part of a workflow invocation, delete intermediates aborted.")
return
Expand Down

0 comments on commit cd47ef6

Please sign in to comment.