Apply suggestions from code review

Co-authored-by: Nuwan Goonasekera <[email protected]>
galaxyproject · Sep 14, 2023 · c617389 · c617389
1 parent 4c8e526
commit c617389
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/galaxy/config/sample/file_sources_conf.yml.sample b/lib/galaxy/config/sample/file_sources_conf.yml.sample
@@ -201,6 +201,6 @@
 - type: onedata
   id: onedata1
   label: Onedata
-  doc: Your Onedata files - configure an access token via the user preferences
+  doc: Your Onedata files - configure an access token via user preferences
   accessToken: ${user.preferences['onedata|access_token']}
   onezoneDomain: ${user.preferences['onedata|onezone_domain']}
diff --git a/lib/galaxy/files/sources/onedata.py b/lib/galaxy/files/sources/onedata.py
@@ -21,9 +21,9 @@ class OnedataFilesSource(PyFilesystem2FilesSource):
 
     def _open_fs(self, user_context=None, opts: Optional[FilesSourceOptions] = None):
         props = self._serialization_props(user_context)
-        onezone_domain = props.pop("onezoneDomain", {}) or ""
+        onezone_domain = props.pop("onezoneDomain", "") or ""
         onezone_domain = remove_prefix("http://", remove_prefix("https://", onezone_domain))
-        access_token = props.pop("accessToken", {}) or ""
+        access_token = props.pop("accessToken", "") or ""
         handle = OnedataRESTFS(onezone_domain, access_token)
         return handle