Increase readability

galaxyproject · Feb 12, 2024 · b7b5c05 · b7b5c05
1 parent 811f8cf
commit b7b5c05
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue b/client/src/components/History/CurrentHistory/HistoryOperations/SelectionOperations.vue
@@ -199,28 +199,19 @@ export default {
     computed: {
         /** @returns {Boolean} */
         canUnhideSelection() {
-            return (
-                this.areAllSelectedHidden ||
-                (HistoryFilters.checkFilter(this.filterText, "visible", "any") && !this.areAllSelectedVisible)
-            );
+            return this.areAllSelectedHidden || (this.isAnyVisibilityAllowed && !this.areAllSelectedVisible);
         },
         /** @returns {Boolean} */
         canHideSelection() {
-            return (
-                this.areAllSelectedVisible ||
-                (HistoryFilters.checkFilter(this.filterText, "visible", "any") && !this.areAllSelectedHidden)
-            );
+            return this.areAllSelectedVisible || (this.isAnyVisibilityAllowed && !this.areAllSelectedHidden);
         },
         /** @returns {Boolean} */
         showDeleted() {
             return !HistoryFilters.checkFilter(this.filterText, "deleted", false);
         },
         /** @returns {Boolean} */
         canDeleteSelection() {
-            return (
-                this.areAllSelectedActive ||
-                (HistoryFilters.checkFilter(this.filterText, "deleted", "any") && !this.areAllSelectedDeleted)
-            );
+            return this.areAllSelectedActive || (this.isAnyDeletedStateAllowed && !this.areAllSelectedDeleted);
         },
         /** @returns {Boolean} */
         canUndeleteSelection() {
@@ -289,6 +280,12 @@ export default {
             }
             return true;
         },
+        isAnyVisibilityAllowed() {
+            return HistoryFilters.checkFilter(this.filterText, "visible", "any");
+        },
+        isAnyDeletedStateAllowed() {
+            return HistoryFilters.checkFilter(this.filterText, "deleted", "any");
+        },
     },
     watch: {
         hasSelection(newVal) {