Skip to content

Commit

Permalink
Merge pull request #17613 from nsoranzo/release_23.2_get_or_create_de…
Browse files Browse the repository at this point in the history
…fault_history_twice

[23.2] Don't call ``get_or_create_default_history()`` twice for invalidated sessions
  • Loading branch information
mvdbeek authored Mar 6, 2024
2 parents 4752af0 + 7ffc2b7 commit 98c80e7
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/galaxy/webapps/base/webapp.py
Original file line number Diff line number Diff line change
Expand Up @@ -664,10 +664,6 @@ def _ensure_valid_session(self, session_cookie: str, create: bool = True) -> Non
self.sa_session.add(prev_galaxy_session)
with transaction(self.sa_session):
self.sa_session.commit()
# If the old session was invalid, get a new (or existing default,
# unused) history with our new session
if invalidate_existing_session:
self.get_or_create_default_history()

def _ensure_logged_in_user(self, session_cookie: str) -> None:
# The value of session_cookie can be one of
Expand Down

0 comments on commit 98c80e7

Please sign in to comment.