Consider only regex as regular expression

`expression` is just a Python (eval) expression.
galaxyproject · Sep 13, 2023 · 8d636ef · 8d636ef
1 parent 5866764
commit 8d636ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/galaxy/tool_util/linters/inputs.py b/lib/galaxy/tool_util/linters/inputs.py
@@ -400,7 +400,7 @@ def lint_inputs(tool_source: "ToolSource", lint_ctx: "LintContext"):
                     lint_ctx.error(
                         f"Parameter [{param_name}]: {vtype} validators are expected to contain text", node=validator
                     )
-                else:
+                elif vtype == "regex":
                     try:
                         re.compile(validator.text)
                     except Exception as e:

diff --git a/test/unit/tool_util/test_tool_linters.py b/test/unit/tool_util/test_tool_linters.py
@@ -410,7 +410,7 @@
             <validator type="in_range">TEXT</validator>
             <validator type="regex" filename="blah"/>
             <validator type="expression"/>
-            <validator type="expression">[</validator>
+            <validator type="regex">[</validator>
             <validator type="value_in_data_table"/>
         </param>
         <param name="another_param_name" type="data" format="bed">