Skip to content

Commit

Permalink
Fix lost reports when switching workflow versions
Browse files Browse the repository at this point in the history
We serialize workflow.reports, but we were only setting it on the
workflow instance if the markdown editor emits it.

Fixes a part of #17903
  • Loading branch information
mvdbeek committed Apr 4, 2024
1 parent e970ae5 commit 8630e3b
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions client/src/components/Workflow/Editor/Index.vue
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@
<MarkdownEditor
v-else
:markdown-text="markdownText"
:markdown-config="markdownConfig"
:markdown-config="report"
mode="report"
:title="'Workflow Report: ' + name"
:steps="steps"
Expand Down Expand Up @@ -310,7 +310,6 @@ export default {
data() {
return {
isCanvas: true,
markdownConfig: null,
markdownText: null,
versions: [],
parameters: null,
Expand Down Expand Up @@ -762,8 +761,8 @@ export default {
const report = data.report || {};
const markdown = report.markdown || reportDefault;
this.report = report;
this.markdownText = markdown;
this.markdownConfig = report;
this.hideModal();
this.stateMessages = getStateUpgradeMessages(data);
const has_changes = this.stateMessages.length > 0;
Expand Down

0 comments on commit 8630e3b

Please sign in to comment.