Merge pull request #17860 from davelopez/24.0_fix_activity_bar_unreac…

…hable [24.0] Fix activity bar unreachable in some pages
galaxyproject · Mar 28, 2024 · 7155ad7 · 7155ad7
2 parents f4115bb + b301e01
commit 7155ad7
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/client/src/entry/analysis/menu.js b/client/src/entry/analysis/menu.js
@@ -53,7 +53,6 @@ export function fetchMenu(options = {}) {
                 {
                     title: _l("Data Libraries"),
                     url: "/libraries",
-                    target: "_top",
                 },
                 {
                     title: _l("Datasets"),
@@ -91,7 +90,6 @@ export function fetchMenu(options = {}) {
                 {
                     title: _l("Data Libraries"),
                     url: "/libraries",
-                    target: "_top",
                 },
                 {
                     title: _l("Histories"),
@@ -123,7 +121,6 @@ export function fetchMenu(options = {}) {
             url: "/admin",
             tooltip: _l("Administer this Galaxy"),
             cls: "admin-only",
-            target: "_top",
         });
     }
 

diff --git a/client/src/entry/analysis/modules/Base.vue b/client/src/entry/analysis/modules/Base.vue
@@ -1,3 +1,3 @@
 <template>
-    <router-view :key="$route.fullPath" class="m-2" />
+    <router-view :key="$route.fullPath" />
 </template>
diff --git a/client/src/entry/analysis/router.js b/client/src/entry/analysis/router.js
@@ -105,9 +105,6 @@ export function getRouter(Galaxy) {
         base: getAppRoot(),
         mode: "history",
         routes: [
-            ...AdminRoutes,
-            ...LibraryRoutes,
-            ...StorageDashboardRoutes,
             /** Login entry route */
             {
                 path: "/login/start",
@@ -171,6 +168,9 @@ export function getRouter(Galaxy) {
                 path: "/",
                 component: Analysis,
                 children: [
+                    ...AdminRoutes,
+                    ...LibraryRoutes,
+                    ...StorageDashboardRoutes,
                     {
                         path: "",
                         alias: "root",