Fix typing issue in reused variable

galaxyproject · Jun 7, 2024 · 67fd140 · 67fd140
1 parent 3a3bbfb
commit 67fd140
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/lib/galaxy/webapps/galaxy/services/users.py b/lib/galaxy/webapps/galaxy/services/users.py
@@ -259,9 +259,7 @@ def get_index(
                 for key, value in user_dict.items():
                     if key in expose_keys:
                         limited_user[key] = value
-                user = LimitedUserModel(**limited_user)
+                rval.append(LimitedUserModel(**limited_user))
             else:
-                user = UserModel(**user_dict)
-
-            rval.append(user)
+                rval.append(UserModel(**user_dict))
         return rval