Skip to content

Commit

Permalink
Merge pull request #17724 from jmchilton/popover_fix_24.0
Browse files Browse the repository at this point in the history
[24.0] Fix date range popover cutoff in history swtich
  • Loading branch information
mvdbeek authored Mar 15, 2024
2 parents 845e306 + 12a79da commit 5c9e2c1
Showing 1 changed file with 20 additions and 2 deletions.
22 changes: 20 additions & 2 deletions client/src/components/History/Modals/SelectorModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -100,16 +100,27 @@ function selectHistories() {
function setFilterValue(newFilter: string, newValue: string) {
filter.value = HistoriesFilters.setFilterValue(filter.value, newFilter, newValue);
}
// hacky workaround for popovers in date pickers being cutoff
// https://github.com/galaxyproject/galaxy/issues/17711
const modalBodyClasses = computed(() => {
return [
"history-selector-modal-body",
showAdvanced.value
? "history-selector-modal-body-allow-overflow"
: "history-selector-modal-body-prevent-overflow",
];
});
</script>

<template>
<div>
<BModal
ref="modal"
v-model="propShowModal"
body-class="history-selector-modal-body"
content-class="history-selector-modal-content"
v-bind="$attrs"
:body-class="modalBodyClasses"
static
centered
hide-footer
Expand Down Expand Up @@ -174,11 +185,18 @@ function setFilterValue(newFilter: string, newValue: string) {
with scoped or lang="scss" */
.history-selector-modal-body {
overflow: hidden;
display: flex;
flex-direction: column;
}
.history-selector-modal-body-allow-overflow {
overflow: visible;
}
.history-selector-modal-body-prevent-overflow {
overflow: hidden;
}
.history-selector-modal-content {
max-height: 80vh !important;
}
Expand Down

0 comments on commit 5c9e2c1

Please sign in to comment.