fix failing jests and move heading to header slot

galaxyproject · May 20, 2024 · 55c011a · 55c011a
1 parent dd18c1e
commit 55c011a
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 6 deletions.
diff --git a/client/src/components/ActivityBar/ActivitySettings.test.js b/client/src/components/ActivityBar/ActivitySettings.test.js
@@ -29,10 +29,7 @@ function testActivity(id, newOptions = {}) {
 }
 
 async function testSearch(wrapper, query, result) {
-    const searchField = wrapper.find("input");
-    searchField.element.value = query;
-    searchField.trigger("change");
-    await wrapper.vm.$nextTick();
+    await wrapper.setProps({ query });
     const filtered = wrapper.findAll(activityItemSelector);
     expect(filtered.length).toBe(result);
 }
@@ -48,6 +45,9 @@ describe("ActivitySettings", () => {
         wrapper = mount(mountTarget, {
             localVue,
             pinia,
+            props: {
+                query: "",
+            },
             stubs: {
                 icon: { template: "<div></div>" },
             },

diff --git a/client/src/components/ActivityBar/ActivitySettings.vue b/client/src/components/ActivityBar/ActivitySettings.vue
@@ -23,7 +23,7 @@ const activityStore = useActivityStore();
 const { activities } = storeToRefs(activityStore);
 
 const filteredActivities = computed(() => {
-    if (props.query.length > 0) {
+    if (props.query?.length > 0) {
         const queryLower = props.query.toLowerCase();
         const results = activities.value.filter((a: Activity) => {
             const attributeValues = [a.title, a.description];

diff --git a/client/src/components/admin/AdminPanel.test.js b/client/src/components/admin/AdminPanel.test.js
@@ -14,6 +14,10 @@ jest.mock("@/composables/config", () => ({
     })),
 }));
 
+jest.mock("vue-router/composables", () => ({
+    useRoute: jest.fn(() => ({})),
+}));
+
 function createTarget(propsData = {}) {
     return mount(MountTarget, {
         localVue,

diff --git a/client/src/components/admin/AdminPanel.vue b/client/src/components/admin/AdminPanel.vue
@@ -125,7 +125,9 @@ const sections = computed(() => {
 
 <template>
     <ActivityPanel v-if="isConfigLoaded" title="Administration" go-to-all-title="Admin Home" href="/admin">
-        <h3>Galaxy Version {{ adminProperties.versionMajor }}</h3>
+        <template v-slot:header>
+            <h3>Galaxy Version {{ adminProperties.versionMajor }}</h3>
+        </template>
         <div class="unified-panel-body">
             <div class="toolMenuContainer">
                 <div class="toolSectionWrapper">