Copy the collection contents by default when copying a collection

That got left out when creating the new multi history view. Fixes #16716 and #16619.
galaxyproject · Sep 21, 2023 · 53074a0 · 53074a0
1 parent 1eabd67
commit 53074a0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/client/src/schema/schema.ts b/client/src/schema/schema.ts
@@ -2445,8 +2445,8 @@ export interface components {
             content?: string | string;
             /**
              * Copy Elements
-             * @description If the source is a collection, whether to copy child HDAs into the target history as well, defaults to False but this is less than ideal and may be changed in future releases.
-             * @default false
+             * @description If the source is a collection, whether to copy child HDAs into the target history as well. Prior to the galaxy release 23.1 this defaulted to false.
+             * @default true
              */
             copy_elements?: boolean;
             /**
@@ -2616,7 +2616,7 @@ export interface components {
             /**
              * Copy Elements
              * @description Whether to create a copy of the source HDAs for the new collection.
-             * @default false
+             * @default true
              */
             copy_elements?: boolean;
             /**

diff --git a/lib/galaxy/schema/schema.py b/lib/galaxy/schema/schema.py
@@ -1366,7 +1366,7 @@ class CreateNewCollectionPayload(Model):
         description="Whether to mark the original HDAs as hidden.",
     )
     copy_elements: Optional[bool] = Field(
-        default=False,
+        default=True,
         title="Copy Elements",
         description="Whether to create a copy of the source HDAs for the new collection.",
     )

diff --git a/lib/galaxy/webapps/galaxy/services/history_contents.py b/lib/galaxy/webapps/galaxy/services/history_contents.py
@@ -239,12 +239,11 @@ class CreateHistoryContentPayloadFromCollection(CreateHistoryContentPayloadFromC
         description="TODO",
     )
     copy_elements: Optional[bool] = Field(
-        default=False,
+        default=True,
         title="Copy Elements",
         description=(
             "If the source is a collection, whether to copy child HDAs into the target "
-            "history as well, defaults to False but this is less than ideal and may "
-            "be changed in future releases."
+            "history as well. Prior to the galaxy release 23.1 this defaulted to false."
         ),
     )