Merge pull request #17679 from mvdbeek/fix_npz_sniffer

[23.2] Assert that at least one file in npz zipfile ends with .npy
galaxyproject · Mar 13, 2024 · 52ca282 · 52ca282
2 parents 93eb541 + fd5fd15
commit 52ca282
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/galaxy/datatypes/binary.py b/lib/galaxy/datatypes/binary.py
@@ -4297,9 +4297,9 @@ def __init__(self, **kwd):
 
     def sniff(self, filename: str) -> bool:
         try:
-            npz = np.load(filename)
-            if isinstance(npz, np.lib.npyio.NpzFile):
-                return True
+            with np.load(filename) as npz:
+                if isinstance(npz, np.lib.npyio.NpzFile) and any(f.filename.endswith(".npy") for f in npz.zip.filelist):
+                    return True
         except Exception:
             return False
         return False