Merge pull request #17199 from ahmedhamidawan/single_item_selector_pl…

…aceholder_bug [23.2] Remove `SingleItemSelector` deselect label, fix history filters hidden on smaller screen
galaxyproject · Dec 22, 2023 · 02f44b4 · 02f44b4
2 parents b65be82 + e87c9ee
commit 02f44b4
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 2 deletions.
diff --git a/client/src/components/History/Index.vue b/client/src/components/History/Index.vue
@@ -1,5 +1,8 @@
 <template>
-    <div v-if="currentUser && currentHistory" id="current-history-panel" class="d-flex flex-column history-index">
+    <div
+        v-if="currentUser && currentHistory"
+        id="current-history-panel"
+        class="d-flex flex-column history-index overflow-auto">
         <HistoryPanel
             v-if="!breadcrumbs.length"
             :list-offset="listOffset"

diff --git a/client/src/components/Panels/Menus/PanelViewMenu.vue b/client/src/components/Panels/Menus/PanelViewMenu.vue
@@ -1,5 +1,14 @@
 <template>
+    <b-button
+        v-if="showAdvanced"
+        variant="link"
+        class="w-100"
+        size="sm"
+        @click="$emit('update:show-advanced', !showAdvanced)">
+        <slot name="panel-view-selector"></slot><span class="sr-only">Close advanced tool search menu</span>
+    </b-button>
     <b-dropdown
+        v-else
         v-b-tooltip.hover.top.noninteractive
         right
         block
@@ -59,6 +68,10 @@ export default {
         currentPanelView: {
             type: String,
         },
+        showAdvanced: {
+            type: Boolean,
+            default: false,
+        },
         storeLoading: {
             type: Boolean,
             default: false,

diff --git a/client/src/components/Panels/ToolPanel.vue b/client/src/components/Panels/ToolPanel.vue
@@ -139,6 +139,7 @@ function onInsertWorkflowSteps(workflowId: string, workflowStepCount: number | u
                     v-if="panelViews && Object.keys(panelViews).length > 1"
                     :panel-views="panelViews"
                     :current-panel-view="currentPanelView"
+                    :show-advanced.sync="showAdvanced"
                     :store-loading="loading"
                     @updatePanelView="updatePanelView">
                     <template v-slot:panel-view-selector>

diff --git a/client/src/components/SingleItemSelector.vue b/client/src/components/SingleItemSelector.vue
@@ -4,7 +4,7 @@
         <Multiselect
             v-if="items"
             v-model="selectedItem"
-            deselect-label="Can't remove this value"
+            :deselect-label="null"
             track-by="id"
             label="text"
             :options="items"