Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Added build log and jacoco report generation/uploading #982

Merged
merged 3 commits into from
Aug 22, 2024

Conversation

jaydee029
Copy link
Contributor

For issue galasa-dev/projectmanagement#1965

(Re-Raised)

@galasa-team
Copy link
Contributor

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Dhruv - my colleague and I discussed some things this morning so based on that I'd like you to make the requested changes and also add the upload of the Gradle build log and unit test reports to the PR build as well as the main build please. If someone in the team is trying to open a PR and their PR build fails, they will want access to these artefacts too, more so than someone monitoring the Main builds.

Please make these changes for the Managers build and I'll add this same comment on to other workflows with open PRs. The completed ones without open PRs we can handle later.

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
@galasa-team
Copy link
Contributor

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

@galasa-team
Copy link
Contributor

Automatic triggering of the build is cancelled as user is not a member of the approved groups. Please ask an admin to review this PR and create a comment on the PR stating 'Approved for building'

@jaydee029
Copy link
Contributor Author

Hi Dhruv - my colleague and I discussed some things this morning so based on that I'd like you to make the requested changes and also add the upload of the Gradle build log and unit test reports to the PR build as well as the main build please. If someone in the team is trying to open a PR and their PR build fails, they will want access to these artefacts too, more so than someone monitoring the Main builds.

Please make these changes for the Managers build and I'll add this same comment on to other workflows with open PRs. The completed ones without open PRs we can handle later.

done

Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for building

@galasa-team
Copy link
Contributor

Build successful

@jadecarino jadecarino merged commit a1ef630 into galasa-dev:main Aug 22, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants