Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added detect-secrets to github workflow #307

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added detect-secrets to github workflow #307

wants to merge 4 commits into from

Conversation

aashir21
Copy link
Contributor

@aashir21 aashir21 commented Nov 25, 2024 •
edited
Loading

@aashir21
Added detect-secrets script to CLI
fa8b707 
Signed-off-by: Aashir Siddiqui <[email protected]>
jadecarino
jadecarino requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change but looks good otherwise

.github/workflows/pr-build.yml Outdated Show resolved Hide resolved
@aashir21 aashir21 changed the title ash detect secrets Add detect-secrets to github workflow Nov 25, 2024
@aashir21 aashir21 changed the title Add detect-secrets to github workflow Added detect-secrets to github workflow Nov 25, 2024
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-307-rg4sr for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-307-lgqk7 for details. If you are unable to do so, please contact a member of the Galasa team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadecarino jadecarino jadecarino requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aashir21 @galasa-team @jadecarino