Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JVM launching -D parameters should be passed before the -jar parameter to have any effect #275

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

techcobweb
Copy link
Contributor

@techcobweb techcobweb commented Aug 26, 2024

Signed-off-by: Mike Cobbett [email protected]

Why ?

Overrides not being set properly. In my environment, it's because the GALASA_HOME environment variable, or the --galasahome parameter on galasactl is not being passed correctly to the JVM.

See the story driving this investigation here: galasa-dev/projectmanagement#1916

@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-275-rlnw7 for details. If you are unable to do so, please contact a member of the Galasa team.

@galasa-team
Copy link

Build successful

@techcobweb techcobweb merged commit 8a37d12 into main Aug 27, 2024
6 checks passed
@techcobweb techcobweb deleted the mcobbett-galasa-home-passed-correctly branch August 27, 2024 16:02
aashir21 pushed a commit that referenced this pull request Sep 18, 2024
…r to have any effect (#275)

Signed-off-by: Mike Cobbett <[email protected]>
Signed-off-by: Aashir Siddiqui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants