Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare images by pixels instead of bytes #208

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Compare images by pixels instead of bytes #208

merged 3 commits into from
Feb 5, 2024

Conversation

eamansour
Copy link
Member

Changes:

  • Resolves test failures on different clients due to imperceptible variations in RGB values by comparing image pixels instead of bytes and using monochrome comparisons

@eamansour eamansour changed the title Em image comparison fix Compare images by pixels instead of bytes Feb 1, 2024
@galasa-team
Copy link

Build failed, see http://localhost:8001/api/v1/namespaces/tekton-pipelines/services/tekton-dashboard:http/proxy/#/namespaces/galasa-build/pipelineruns/repo-cli-pr-208-n4qpn for details. If you are unable to do so, please contact a member of the Galasa team.

@eamansour
Empty commit to kick off build
0a768b0 
Signed-off-by: Eamonn Mansour <[email protected]>
@galasa-team
Copy link

Build successful

jadecarino
jadecarino approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@jadecarino jadecarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for making this change!

@eamansour eamansour merged commit 0c7a34b into main Feb 5, 2024
4 checks passed
@eamansour eamansour deleted the em-image-comparison-fix branch February 5, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadecarino jadecarino jadecarino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eamansour @galasa-team @jadecarino