Parameterise inttest ingress to be able to deploy on different servers #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eamonn Mansour <[email protected]>
Signed-off-by: Eamonn Mansour <[email protected]>
|
Build successful |
jadecarino
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
See galasa-dev/projectmanagement#1749
In order to host the maven repo for the inttests that run internally, the Ingress needs to be able to point at a different host with different TLS settings. This PR updates the helm chart to allow this to be possible.
Also replaced a hardcoded CONTEXTROOT suffix with a value matching the Ingress path to allow the inttests to be served on different paths than
/{branch}/maven-repo/inttests