fix: block component block not available yet #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kilted-andres
force-pushed
the
xw/fix_block_component
branch
from
d303046
to
94098df
Compare
kilted-andres
changed the title
arty-name
approved these changes
Sep 11, 2024
| @@ -16,7 +16,7 @@ const { title, id, description, attestationsCreated, tags } = | |||
| <li class=`${containerStyles.container} container`> | |||
| <h2> | |||
| <a href={generatePath(paths.ctypeDetails, id)} class="title"> | |||
| {title} | |||
| {title.length > 0 ? title : '∅'} | |||
There was a problem hiding this comment.
It’s unclear to me whether this is still needed, but okay. This could also be spelled simpler by the way.
Suggested change
| {title.length > 0 ? title : '∅'} | |
| {title || '∅'} |
There was a problem hiding this comment.
I thought "" was truthty, but you are right it is falsy, so that's possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a regression test after ctypehub/pull/743, it was found that the "Registration Block" component was showing a broken link after creating a cType from inside the app. This was because the block was still not available and the link required the block number.
Now:
When submitting a cType creation transaction, it will be awaited until it is InBlock.Other fix:
Handle cTypes without a title.