Skip to content

Commit

Permalink
chore: upgrade node version to >=20 and other minor improvements (#739)
Browse files Browse the repository at this point in the history
* feat: corepack set packageManager field on package.json file

* fix: update to latest version of pnpm

* fix: only require major version of node in package.json

* feat: .nvmrc in case someone uses it

* chore: set pnpm/action-setup to v4

* chore: update aws-actions/configure-aws-credentials to v4

* fix: for docker alpine specify only major node version

* fix: delete the pnpm version hash from package.json
  • Loading branch information
kilted-andres authored Jul 23, 2024
1 parent cdfad35 commit e0702a9
Show file tree
Hide file tree
Showing 10 changed files with 6,433 additions and 5,072 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/dev-ci-cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
uses: actions/checkout@v4

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/production-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
uses: actions/checkout@v4

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/production-restart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
uses: actions/checkout@v4

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ jobs:
uses: actions/checkout@v4

- name: Configure package manager
uses: pnpm/action-setup@v2
with:
version: latest
uses: pnpm/action-setup@v4

- name: Configure Node
uses: actions/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/staging-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
uses: actions/checkout@v4

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/staging-restart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
uses: actions/checkout@v4

- name: Configure AWS credentials
uses: aws-actions/configure-aws-credentials@v1-node16
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }}
aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
Expand Down
1 change: 1 addition & 0 deletions .nvmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
lts/Iron
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:20.14.0-alpine AS base
FROM node:20-alpine AS base
WORKDIR /app

RUN npm install --global pnpm
Expand Down
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
"repository": "[email protected]:galaniprojects/ctypehub.git",
"license": "BSD-4-Clause",
"type": "module",
"packageManager": "[email protected]",
"engines": {
"node": ">= 20.14.0"
"node": ">=20"
},
"scripts": {
"prettify": "prettier --write \"src/**/*.astro\" \"src/**/*.ts*\" \"src/**/*.css*\"",
Expand Down Expand Up @@ -79,4 +80,4 @@
"vitest": "^0.34.6",
"vitest-github-actions-reporter": "^0.11.1"
}
}
}
Loading

0 comments on commit e0702a9

Please sign in to comment.