Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Written file includes webpack-dev-server client modules #35

Open
hellochar opened this issue Feb 8, 2017 · 0 comments
Open

Written file includes webpack-dev-server client modules #35

hellochar opened this issue Feb 8, 2017 · 0 comments

Comments

@hellochar
Copy link

hellochar commented Feb 8, 2017 •
edited
Loading

Using inline mode, WriteFilePlugin is emitting the webpack-dev-server client entry code into my bundle:

// bundle.js

...my bundle...

+ansiHTML.setColors(colors);
+
+function createOverlayIframe(onIframeLoad) {
+       var iframe = document.createElement("iframe");
+       iframe.id = "webpack-dev-server-client-overlay";
+       iframe.src = "about:blank";
+       iframe.style.position
+... about 300k filesize of bundle code

I ship this bundle as a standalone artifact so obviously I can't have this emitted. I'd like the convenience of inline mode though; is that possible to support?
hellochar added a commit to palantir/plottable that referenced this issue Feb 8, 2017
@hellochar
fix grunt; fix npm run start; watch writes to plottable.js
cf6fda7 
webpack-dev-server now emits the plottable.js file as it gets changed.
Unfortunately, because of gajus/write-file-webpack-plugin#35
I turned off livereloading unless you use the localhost:9999/webpack-dev-server/<filepath>
url.
@hellochar hellochar mentioned this issue Feb 8, 2017
Merged
CalvinFernandez pushed a commit to palantir/plottable that referenced this issue Feb 9, 2017
@hellochar @CalvinFernandez
fix grunt; fix npm run start; write to plottable.js while dev-wat…
96850e2 
…ching (#3225)

* fix `grunt`; fix `npm run start`; watch writes to plottable.js

webpack-dev-server now emits the plottable.js file as it gets changed.
Unfortunately, because of gajus/write-file-webpack-plugin#35
I turned off livereloading unless you use the localhost:9999/webpack-dev-server/<filepath>
url.

* include write-file-webpack-plugin as a devDependency
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hellochar