v0.1.32; fix direction="X" regression

gadicc · Feb 2, 2015 · 630e1fc · 630e1fc
1 parent 5e9a1ce
commit 630e1fc
Show file tree

Hide file tree

Showing 6 changed files with 11 additions and 5 deletions.
diff --git a/.versions b/.versions
@@ -10,7 +10,7 @@ [email protected]
 [email protected]
 [email protected]
 [email protected]
-gadicohen:[email protected].31-pre.3
+gadicohen:[email protected].32
 [email protected]
 [email protected]
 [email protected]
@@ -19,7 +19,7 @@ jag:[email protected]
 [email protected]
 [email protected]
 [email protected]
-local-test:gadicohen:[email protected].31-pre.3
+local-test:gadicohen:[email protected].32
 [email protected]
 [email protected]
 [email protected]

diff --git a/History.md b/History.md
@@ -1,5 +1,9 @@
 ## vNEXT
 
+## v0.1.32
+
+* Bugfix (#famous regression): direction="X" now works again
+
 ## v0.1.31
 
 * Bugfix (#famous regression): Revert back to Blaze.render (for non-Surfaces)

diff --git a/demo-famono/.meteor/versions b/demo-famono/.meteor/versions
@@ -15,7 +15,7 @@ [email protected]
 [email protected]
 [email protected]
 [email protected]
-gadicohen:[email protected].31
+gadicohen:[email protected].32
 gadicohen:[email protected]
 gadicohen:[email protected]
 gadicohen:[email protected]

diff --git a/lib/famous-views.js b/lib/famous-views.js
@@ -187,7 +187,8 @@ var optionBlaze = function(string, key, blazeView) {
 
 optionString = function(string, key, blazeView) {
   // special handling based on special key names
-  if (key === 'direction' && famous.utilities.Utility.Direction[string])
+  if (key === 'direction' &&
+      typeof famous.utilities.Utility.Direction[string] !== 'undefined')
     return famous.utilities.Utility.Direction[string];
   if (key === 'id')
     return string;

diff --git a/package.js b/package.js
@@ -1,7 +1,7 @@
 Package.describe({
   name: "gadicohen:famous-views",
   summary: 'Blaze Views for Famous; doing Famous Meteor-style',
-  version: "0.1.31",
+  version: "0.1.32",
   git: "https://github.com/gadicc/meteor-famous-views.git"
 });
 

diff --git a/tests/famous.js b/tests/famous.js
@@ -58,6 +58,7 @@ Tinytest.addAsync('famous-views - famous.js - direction', function(test, complet
 	var optionView = null;
 	var optionCount = 0;
 	var optionTests = [
+		{ given: "X", expect: famous.utilities.Utility.Direction.X }, // key name (value 0)
 		{ given: "Y", expect: famous.utilities.Utility.Direction.Y }, // key name
 		{ given: "1", expect: famous.utilities.Utility.Direction.Y }, // string numeral
 		{ given: 1, expect: famous.utilities.Utility.Direction.Y }    // number