Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide non-API functions #2895

Open
wants to merge 2 commits into
base: v1.x
Choose a base branch
from
Open

Hide non-API functions #2895

wants to merge 2 commits into from

Commits on Oct 9, 2023

  1. Hide non-API functions when position independent code is enabled 

    Usage of -fvisibility=hidden is the recommended default for DSO's.

If the spdlog build is for a shared library, then API symbols have
SPDLOG_API marking on them, and cause the symbol to be exported, with
other symbols now hidden by default.

If the build is for a static library with position-independent code, then
spdlog is to be embedded as implementation detail in another shared
library or executable. In that case we don't want to export any symbol.
Conveniently, SPDLPG_API in that case resolves to nothing, so with the
default of hidden all symbols are made hidden.
    @urisimchoni
    urisimchoni committed Oct 9, 2023
    Configuration menu
    Copy the full SHA
    894f26b View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. Hide non-API functions unconditionally

    @urisimchoni
    urisimchoni committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    f402337 View commit details
    Browse the repository at this point in the history