Seqref updates #573
Draft
Seqref updates #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahwagner
commented
Oct 28, 2024
| $ref: "#/$defs/SequenceString" | ||
| description: >- | ||
| A :ref:`SequenceString` that is a literal representation of the referenced sequence. | ||
| moleculeType: |
There was a problem hiding this comment.
@cmprocknow concern about "molecule type"; perhaps "molecularContext" would be cleaner.
ahwagner
commented
Oct 28, 2024
| moleculeType: | ||
| type: string | ||
| enum: | ||
| - genomic |
There was a problem hiding this comment.
general discussion on genomic expressed concerns, possible alternate is "template"
There was a problem hiding this comment.
except "template" is a total non-starter. There are genomic variants that are not necessarily going to be involved as template sequence (e.g. variants in regulatory elements)
There was a problem hiding this comment.
Group consensus: we should cover the same concept types that RefSeq uses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #567 and #568. For discussion.