fix: types

g59 · Jan 20, 2024 · 26eb5db · 26eb5db
1 parent 303b036
commit 26eb5db
Show file tree

Hide file tree

Showing 16 changed files with 43 additions and 35 deletions.
diff --git a/example/package.json b/example/package.json
@@ -8,10 +8,9 @@
   "scripts": {
     "build": "nest build",
     "clean": "rimraf dist",
+    "prebuild": "rimraf dist",
     "lint": "tsc -p . --noEmit",
-    "start": "nest start",
-    "start:dev": "nest start --watch",
-    "test": "jest"
+    "start": "nest start --watch"
   },
   "dependencies": {
     "@apollo/server": "^4.10.0",

diff --git a/example/src/schema.gql b/example/src/schema.gql
@@ -6,13 +6,6 @@ interface Node {
   id: ID!
 }
 
-type PageInfo {
-  startCursor: String
-  endCursor: String
-  hasPreviousPage: Boolean!
-  hasNextPage: Boolean!
-}
-
 type Recipe implements Node {
   id: ID!
   title: String!
@@ -26,6 +19,13 @@ A date-time string at UTC, such as 2019-12-03T09:54:33Z, compliant with the date
 """
 scalar DateTime
 
+type PageInfo {
+  startCursor: String
+  endCursor: String
+  hasPreviousPage: Boolean!
+  hasNextPage: Boolean!
+}
+
 type RecipesConnection {
   pageInfo: PageInfo!
   edges: [RecipesEdge!]!

diff --git a/example/tsconfig.build.json b/example/tsconfig.build.json
@@ -1,4 +1,4 @@
 {
   "extends": "./tsconfig.json",
-  "exclude": ["node_modules", "test", "dist", "**/*spec.ts"]
+  "exclude": ["__tests__/*", "*.spec.ts"]
 }
diff --git a/example/tsconfig.json b/example/tsconfig.json
@@ -1,11 +1,11 @@
 {
+  "extends": "../tsconfig.json",
   "compilerOptions": {
     "declaration": true,
     "noEmit": false,
     "outDir": "./dist",
     "removeComments": true,
     "sourceMap": true
   },
-  "exclude": ["node_modules", "dist"],
-  "extends": "../tsconfig.json"
+  "exclude": ["__tests__/*", "*.spec.ts"]
 }
diff --git a/packages/nestjs-firebase/package.json b/packages/nestjs-firebase/package.json
@@ -7,7 +7,7 @@
   "main": "lib/index.js",
   "scripts": {
     "build": "npm run clean && tsc -p .",
-    "clean": "rimraf lib",
+    "clean": "tsc --build --clean",
     "lint": "tsc -p . --noEmit"
   },
   "keywords": [

diff --git a/packages/nestjs-firebase/src/firebase.interface.ts b/packages/nestjs-firebase/src/firebase.interface.ts
@@ -1,5 +1,8 @@
 import type { Type } from "@nestjs/common";
-import type { ModuleMetadata } from "@nestjs/common/interfaces";
+import type {
+  FactoryProvider,
+  ModuleMetadata,
+} from "@nestjs/common/interfaces";
 import * as firebaseAdmin from "firebase-admin";
 import { AppOptions } from "firebase-admin";
 
@@ -12,7 +15,7 @@ export type FirebaseModuleAsyncOptions = {
   useFactory?: (
     ...args: unknown[]
   ) => Promise<FirebaseModuleOptions> | FirebaseModuleOptions;
-  inject?: unknown[];
+  inject?: FactoryProvider<FirebaseModuleOptions>["inject"];
   useExisting?: Type<FirebaseModuleOptionsFactory>;
 } & Pick<ModuleMetadata, "imports">;
 

diff --git a/packages/nestjs-firebase/tsconfig.json b/packages/nestjs-firebase/tsconfig.json
@@ -4,6 +4,6 @@
     "outDir": "./lib",
     "noEmit": false
   },
-  "exclude": ["node_modules", "**/*.spec.ts", "dist"],
+  "exclude": ["__tests__/*", "*.spec.ts"],
   "include": ["src"]
 }
diff --git a/packages/nestjs-graphql-relay/package.json b/packages/nestjs-graphql-relay/package.json
@@ -14,7 +14,7 @@
   "main": "lib/index.js",
   "scripts": {
     "build": "npm run clean && tsc -p .",
-    "clean": "rimraf lib",
+    "clean": "tsc --build --clean",
     "lint": "tsc -p . --noEmit"
   },
   "keywords": [

diff --git a/packages/nestjs-graphql-relay/tsconfig.json b/packages/nestjs-graphql-relay/tsconfig.json
@@ -4,6 +4,6 @@
     "outDir": "./lib",
     "noEmit": false
   },
-  "exclude": ["node_modules", "dist"],
+  "exclude": ["__tests__/*", "*.spec.ts"],
   "include": ["src"]
 }
diff --git a/packages/nestjs-slack-webhook/package.json b/packages/nestjs-slack-webhook/package.json
@@ -14,13 +14,10 @@
   "main": "lib/index.js",
   "scripts": {
     "build": "npm run clean && tsc -p .",
-    "clean": "rimraf lib",
+    "clean": "tsc --build --clean",
     "lint": "tsc -p . --noEmit"
   },
-  "keywords": [
-    "nest",
-    "slack-webhook"
-  ],
+  "keywords": ["nest", "slack-webhook"],
   "peerDependencies": {
     "@nestjs/common": "^10.0.0",
     "@slack/webhook": "^6.0.0 || ^7.0.0"

diff --git a/packages/nestjs-slack-webhook/src/slackOptions.ts b/packages/nestjs-slack-webhook/src/slackOptions.ts
@@ -1,4 +1,8 @@
-import { ModuleMetadata, Type } from "@nestjs/common/interfaces";
+import type {
+  FactoryProvider,
+  ModuleMetadata,
+  Type,
+} from "@nestjs/common/interfaces";
 import { IncomingWebhookDefaultArguments } from "@slack/webhook";
 
 export interface SlackOptions extends IncomingWebhookDefaultArguments {
@@ -10,8 +14,8 @@ export interface SlackOptionsFactory {
 }
 
 export interface SlackAsyncOptions extends Pick<ModuleMetadata, "imports"> {
-  inject?: unknown[];
+  inject?: FactoryProvider["inject"];
   useClass?: Type<SlackOptionsFactory>;
   useExisting?: Type<SlackOptionsFactory>;
-  useFactory?: (...args: unknown[]) => Promise<SlackOptions> | SlackOptions;
+  useFactory?: FactoryProvider<SlackOptions>["useFactory"];
 }
diff --git a/packages/nestjs-slack-webhook/tsconfig.json b/packages/nestjs-slack-webhook/tsconfig.json
@@ -4,6 +4,6 @@
     "outDir": "./lib",
     "noEmit": false
   },
-  "exclude": ["node_modules", "dist"],
+  "exclude": ["__tests__/*", "*.spec.ts"],
   "include": ["src"]
 }
diff --git a/packages/nestjs-zendesk/package.json b/packages/nestjs-zendesk/package.json
@@ -15,7 +15,7 @@
   "main": "lib/index.js",
   "scripts": {
     "build": "npm run clean && tsc -p .",
-    "clean": "rimraf lib",
+    "clean": "tsc --build --clean",
     "lint": "tsc -p . --noEmit"
   },
   "keywords": [

diff --git a/packages/nestjs-zendesk/src/zendesk.interface.ts b/packages/nestjs-zendesk/src/zendesk.interface.ts
@@ -1,15 +1,17 @@
-import type { ModuleMetadata, Type } from "@nestjs/common/interfaces";
+import type {
+  FactoryProvider,
+  ModuleMetadata,
+  Type,
+} from "@nestjs/common/interfaces";
 import type { ZendeskClientOptions } from "node-zendesk";
 
 export interface ZendeskOptionsFactory {
   createOptions(): Promise<ZendeskClientOptions> | ZendeskClientOptions;
 }
 
 export interface ZendeskAsyncOptions extends Pick<ModuleMetadata, "imports"> {
-  inject?: unknown[];
+  inject?: FactoryProvider["inject"];
   useClass?: Type<ZendeskOptionsFactory>;
   useExisting?: Type<ZendeskOptionsFactory>;
-  useFactory?: (
-    ...args: unknown[]
-  ) => Promise<ZendeskClientOptions> | ZendeskClientOptions;
+  useFactory?: FactoryProvider<ZendeskClientOptions>["useFactory"];
 }
diff --git a/packages/nestjs-zendesk/tsconfig.json b/packages/nestjs-zendesk/tsconfig.json
@@ -4,5 +4,6 @@
     "outDir": "./lib",
     "noEmit": false
   },
+  "exclude": ["__tests__/*", "*.spec.ts"],
   "include": ["src"]
 }
diff --git a/tsconfig.json b/tsconfig.json
@@ -1,4 +1,5 @@
 {
+  "$schema": "https://json.schemastore.org/tsconfig",
   "extends": "@9renpoto/tsconfig",
   "compilerOptions": {
     "emitDecoratorMetadata": true,
@@ -7,6 +8,7 @@
     "moduleResolution": "node",
     "noEmit": true,
     "strictPropertyInitialization": false,
-    "target": "ESNext"
+    "target": "ESNext",
+    "skipLibCheck": true
   }
 }