Merge pull request #1727 from g59/next

refactor: use managed types

.devcontainer/devcontainer.json

@@ -0,0 +1,30 @@
+// For format details, see https://aka.ms/devcontainer.json. For config options, see the
+// README at: https://github.com/devcontainers/templates/tree/main/src/alpine
+{
+	"name": "Alpine",
+	// Or use a Dockerfile or Docker Compose file. More info: https://containers.dev/guide/dockerfile
+	"image": "mcr.microsoft.com/devcontainers/base:alpine-3.18",
+	"features": {
+		"ghcr.io/cirolosapio/devcontainers-features/alpine-node:0": {}
+	},
+	"customizations": {},
+
+	"containerEnv": {
+		"SLACK_WEBHOOK_URL": "https://example.com"
+	}
+
+	// Features to add to the dev container. More info: https://containers.dev/features.
+	// "features": {},
+
+	// Use 'forwardPorts' to make a list of ports inside the container available locally.
+	// "forwardPorts": [],
+
+	// Use 'postCreateCommand' to run commands after the container is created.
+	// "postCreateCommand": "uname -a",
+
+	// Configure tool-specific properties.
+	// "customizations": {},
+
+	// Uncomment to connect as root instead. More info: https://aka.ms/dev-containers-non-root.
+	// "remoteUser": "root"
+}

.github/workflows/npm-publish-packages.yml

@@ -14,13 +14,12 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/[email protected]
         with:
-          node-version: 18
+          node-version: lts/*
       - run: npm ci
       - run: npm run build
       - run: npm test
         env:
           SLACK_WEBHOOK_URL: https://example.com
-          CI: true
 
   publish-gpr:
     needs: build
@@ -29,7 +28,7 @@ jobs:
       - uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1
       - uses: actions/[email protected]
         with:
-          node-version: 18
+          node-version: lts/*
           registry-url: "https://registry.npmjs.org"
       - run: npm ci
       - run: npm run build

example/src/config/zendesk.ts

@@ -1,11 +1,11 @@
 import { registerAs } from "@nestjs/config";
-import type { ClientOptions } from "node-zendesk";
+import type { ZendeskClientOptions } from "node-zendesk";
 
 export default registerAs(
   "zendesk",
-  (): ClientOptions => ({
+  (): ZendeskClientOptions => ({
     username: process.env.ZENDESK_USER_NAME!,
     token: process.env.ZENDESK_TOKEN!,
-    remoteUri: process.env.ZENDESK_REMOTE_URI!,
+    endpointUri: process.env.ZENDESK_REMOTE_URI!,
   }),
 );

example/src/zendesk/zendesk.service.ts

@@ -1,10 +1,10 @@
 import { Injectable } from "@nestjs/common";
 import { InjectZendesk } from "nestjs-zendesk";
-import { Client } from "node-zendesk";
+import { ZendeskClient } from "node-zendesk";
 
 @Injectable()
 export class ZendeskService {
-  constructor(@InjectZendesk() private readonly zendesk: Client) {}
+  constructor(@InjectZendesk() private readonly zendesk: ZendeskClient) {}
 
   async ticket() {
     return this.zendesk.tickets.list();