Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reload whole theme when variant changes on XDG #5250

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

Jacalz
Copy link
Member

@Jacalz Jacalz commented Nov 11, 2024

Description:

This is a small improvement in the XDG theme watching code to make sure that we only change the variant and not do a full theme reload each time given that we know that just the variant changed. The delay when switching between dark and light mode is decreased.

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@coveralls
Copy link

Coverage Status

coverage: 59.957% (-0.001%) from 59.958%
when pulling d515fa8 on Jacalz:theme-change-cleanup
into 85063d5 on fyne-io:develop.

Copy link
Contributor

@dweymouth dweymouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I didn't test it myself but I trust that you verified it :)

@Jacalz Jacalz merged commit 8b37135 into fyne-io:develop Nov 12, 2024
12 checks passed
@Jacalz Jacalz deleted the theme-change-cleanup branch November 12, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants