Allow a theme to override the form factor of the tabs to be mobile #5239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids being forced to respect the singleton device reported from hardware
dweymouth
reviewed
Nov 6, 2024
internal/theme/feature.go
Outdated
| // FeatureTheme defines the method to look up features that we use internally to apply functional | ||
| // differences through a theme override. | ||
| // | ||
| // Since: 2.6 |
There was a problem hiding this comment.
Is this supposed to be a public API (since it has the Since: line)? If so, this should be in the public theme package rather than internal?
There was a problem hiding this comment.
No it wasn't - that doc was just over-enthusiastic
|
Requests were fixed 2 weeks ago, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing from the unfortunately-merged-unmerged #5225
Checklist: