Add a cache for MinSize in BaseWidget #4827
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Jacalz
commented
May 2, 2024
| min := t.BaseWidget.MinSize() | ||
| t.minCache = min | ||
| return min | ||
| // We don't return the cached value as any internal segments could have caused it to change... |
There was a problem hiding this comment.
We should likely fix this as it kind of goes against the idea of refreshing a widget when it changes state. Sounds like a bug but it isn't new behaviour to this PR so I'll let it slide for now.
|
I thought, that I had added some sort of minSize cache back in the days when I worked on the walkers, didn’t I? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This attempts to cache MinSize values of widgets to provide for faster lookups by avoiding recalculations when nothing has changed. I think it feels quite a bit faster when just using fyne_demo. Placebo?
Supersedes #4681
Checklist:
Where applicable: