Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image alignment Rich Text feature/issues #4092

Merged
merged 5 commits into from
Aug 1, 2023
Merged

Image alignment Rich Text feature/issues #4092

merged 5 commits into from
Aug 1, 2023

Conversation

andydotxyz
Copy link
Member

Adds new API to specify image alignment inside RichText ImageSegment.
Also resolve an issue where alignment did not refresh on resize.

Fixes #3810 and #3505

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.
  • Any breaking changes have a deprecation path or have been discussed.
  • Updated the vendor folder (using go mod vendor).
  • Check for binary size increases when importing new modules.

@coveralls
Copy link

coveralls commented Jul 26, 2023 •
edited
Loading

Coverage Status

coverage: 66.438% (+0.3%) from 66.17% when pulling d8801bc on andydotxyz:fix/3810 into 6fd3c28 on fyne-io:develop.

Jacalz
Jacalz reviewed Jul 30, 2023
View reviewed changes
Copy link
Member

@Jacalz Jacalz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there not be some tests for this?

@andydotxyz andydotxyz merged commit ecb8c1a into fyne-io:develop Aug 1, 2023
11 checks passed
@andydotxyz andydotxyz deleted the fix/3810 branch August 1, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jacalz Jacalz Jacalz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andydotxyz @coveralls @Jacalz