Fixes renderer creation on ResponsiveLayout #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue fyne-io#39 - calling the inside object `CreateRenderer` breaks several native behaviors (text wrapping, clickable, and many others). Removing this call and using NewSimpleRenderer on the reponsiveWidget fixes the problems. I don't have precise explanation.
metal3d
changed the title
andydotxyz
approved these changes
Jul 17, 2023
|
Yes this makes sense - you are accidentally assigning a renderer to two different objects I think... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #39 - calling the inside object
CreateRendererbreaks several native behaviors (text wrapping, clickable, and many others).Removing this call and using NewSimpleRenderer on the reponsiveWidget fixes the problems.
I don't have precise explanation.