-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* How to Download section
- Loading branch information
yuko fuyutsuki
committed
Nov 8, 2017
1 parent
1756396
commit dc09ed2
Showing
1 changed file
with
7 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dear @fuyutsuki,
I am writing to notify you that your submitted release, "Texter" (v2.2.5), for the project Texter on 2017-11-08 09:57:46, contains a malformatted description, which has already been edited.
Please keep in mind that Poggit tries to convert your plugin description to tab view, so you should review how your description looks like after submitting the plugin. In particular, make sure you use the correct headers.
The description has already been corrected. Please click "Edit Release" on https://poggit.pmmp.io/p/Texter/2.2.5 to see how I've improved your description layout.
Your plugin has not been rejected and remains on the review queue.
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, I have deleted the section for "Downloads", because it is totally useless. I have explained it in the submit form if you read carefully.
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SOF3 Ok, thank you.
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This still needs to be done.
-TheDeibo
{{Poggit Reviewer}}
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SOF3 @TheDeibo Fixed on 2c369cb .
However, the following 400 error occurs at https://poggit.pmmp.io/update/fuyutsuki/Texter/Texter/8 .
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SOF3
Was self resolved.
However, this should be displayed on the page. Please improve.
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tagging @Awzaw too. :D
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure yet why this behaviour has changed, but maybe non-editable releases shouldn't even display in the dropdown, or be greyed out? Issue created: poggit/poggit#142
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Awzaw Thank you.
There is neither. Also, this was the first release so we did not gray out.
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will also get an error if you try to create a release when a previous build is still 'submitted', but that should also display a message explaining the problem, instead of a 400 Bad Request
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Awzaw No, I certainly did that action and received 400 error, no message was output.
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exactly, you should get a nice error, but you don't at the moment
dc09ed2There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed poggit/poggit#142 in poggit/poggit@6c2cca3