Attribution #9
Merged
Attribution #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. I think you deserve to be listed as 'ctb' - you've contributed a fair bit by answering my questions - with code snippets - and addressing some of needs here in 'mirai'. |
HenrikBengtsson
added a commit
that referenced
this pull request
May 15, 2024
…heck' NOTE, which will require manual intervention on every CRAN submission going forward [#9]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also corrects a typo.
Not sure how this passed CRAN newbies in the first place, but just following convention, thanks!
Also I notice that I'm listed as [ctb] in DESCRIPTION and I don't think that's entirely fair given that you did all the work on this package Henrik! I'm happy to be taken out - it's up to you.