Fix format even if workspace folder cannot be obtained #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 76a82a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ota-meshi
requested changes
Oct 30, 2023
server/src/server.ts
Outdated
| selections: Range[], | ||
| ): Promise<TextEdit[]> { | ||
| // version check | ||
| if (version !== textDocument.version) { |
There was a problem hiding this comment.
バージョンのチェックはawait determineConfigPath(uri, textDocument)よりも後である必要があると思います。非同期中にバージョンが変更される可能性があるためです。
There was a problem hiding this comment.
ありがとうございます、見落としてました。
バージョンのチェックをdetermineConfigPathの後に行うよう直しました。
ota-meshi
deleted the
fix_format_even_if_workspaceFolder_cannot_be_obtained
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workspace folderが取得できない場合でも、デフォルト設定でフォーマットするよう変更しました。
workspace folderが取得できた場合の挙動は変更前後で変わらないようにしています。
また、スネークケースの変数があったのでついでに直しています。