Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable per-SQL-ID log suppression (#322) #332

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

HidekiSugimoto189
Copy link
Contributor

#322 Enable per-SQL-ID log suppression

Create an interface for each logger and modify it so that necessary classes implement it.
Then, to improve performance, the API of SLF4J 2.x was used.

TODO

  • Add API for calling log suppression API from outside.

各Logger用のインタフェースを作成し必要なクラスがimplementsするように修正。
そのうえで性能改善のためSLF4J 2.xのAPIを利用するように変更。

TODO

  • 外部からログ抑止のAPIを呼び出す部分のAPI追加

Also added suppressLogging API
@coveralls
Copy link

coveralls commented Sep 10, 2024

Coverage Status

coverage: 90.35% (-0.9%) from 91.21%
when pulling 82647e5 on feature/enable_per_sql_id_log_suppression
into 336d7e4 on master.

@shout-star
Copy link
Contributor

@HidekiSugimoto189
I am running into the MDC with SqlAgent#suppressLogging, but even if SqlAgent closes, it will remain thread local unless SqlAgent#releaseLogging is called, so I think it would be better to call SqlAgent#releaseLogging automatically at the timing of SqlAgent#close.

@HidekiSugimoto189 HidekiSugimoto189 marked this pull request as ready for review September 12, 2024 03:20
@shout-star shout-star merged commit 0bca727 into master Sep 12, 2024
1 of 3 checks passed
@shout-star shout-star deleted the feature/enable_per_sql_id_log_suppression branch September 12, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants