Updating tokamak_from_plasma to base vertical_build off of inboard bu… #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ild rather than outboard build. When the outboard build is larger than the inboard build, the two options are: 1. Thicknesses to increase on inboard vertical runs (upper-left quadrant in +r being right, +z being up), which causes clashes with central solenoid/VV/TF coil items placed inboard of the IB shield/blanket 2. Thicknesses to increase on outboard vertical runs (upper right quadrant), which pushes out outer blanket. This pushes out the outboard build, which doesn't lead to clashes and is closer to design goals for tokamaks. The other point is that increased thickness should match where neutron doses tend to be higher, which is more pronounced on the outboard side away from the upper/lower (i.e. divertor) regions
|
Many thanks for putting in a PR to fix this, |
|
Sure thing. I'll make another commit later today |
…uild based on an inner radial build
|
Many thanks for this fix, I've run it locally and it looks much better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the issue of inboard build clashes from vertical build being based on outboard radial build.
Sorry for how many changes there are - it's the standard spaces vs tabs debacle. Relevant changes are on lines 179-184 original, 179-188 updated.